Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WALL] Lubega / WALL-5124 / Add api-v2 as externals in webpack config #17465

Merged
merged 3 commits into from
Nov 15, 2024
Merged

[WALL] Lubega / WALL-5124 / Add api-v2 as externals in webpack config #17465

merged 3 commits into from
Nov 15, 2024
+3 −2

Conversation

lubega-deriv
Copy link
Contributor

@lubega-deriv lubega-deriv commented Nov 11, 2024 •
edited
Loading

Changes:

  • Add api-v2 as external in webpack config
  • Fix circular dependency in useAuthorizedQuery

Explanation:

  • For monorepos with a centralized bundling process the build script i.e NX or Lerna would handle the packages collectively and manage the respective packages as part of the build process, hence why api-v2 does not need to be specifically bundled together in the wallets package bundle. In example that multiple packages are using this api-v2 package not adding it as externals might instead cause duplication across bundles and increase overall bundle size due to these additional source code added.

Before:

Bildschirmfoto 2024-11-11 um 12 21 41 PM

After:

Bildschirmfoto 2024-11-11 um 12 21 50 PM Bildschirmfoto 2024-11-11 um 12 23 35 PM

@vercel Vercel
Copy link

vercel bot commented Nov 11, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ✅ Ready (Inspect) Visit Preview Nov 15, 2024 9:14am

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information. 
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17465](https://github.com/deriv-com/deriv-app/pull/17465)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-lubega-deriv-add-api-v2-as-external.binary.sx?qa_server=red.derivws.com&app_id=30370
    - **Original**: https://deriv-app-git-fork-lubega-deriv-add-api-v2-as-external.binary.sx
- **App ID**: `30370`

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 11, 2024 •
edited
Loading

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 26
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-lubega-deriv-add-api-v2-as-external.binary.sx/

@coveralls
Copy link

coveralls commented Nov 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11853163566

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 4 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.002%) to 53.183%
Files with Coverage Reduction New Missed Lines %
packages/trader/src/AppV2/Components/ActiveSymbolsList/active-symbols-list.tsx 4 68.18%
Totals Coverage Status
Change from base Build 11852753532: 0.002%
Covered Lines: 32721
Relevant Lines: 57422
💛 - Coveralls

@lubega-deriv lubega-deriv marked this pull request as ready for review November 12, 2024 08:13
@lubega-deriv lubega-deriv changed the title [WALL] Add api-v2 as external in webpack config [WALL] Lubega / WALL-5124 / Add api-v2 as externals in webpack config Nov 12, 2024
@github-actions GitHub Actions
Copy link
Contributor

⏳ Generating Lighthouse report...

@nijil-deriv nijil-deriv merged commit 048e867 into deriv-com:master Nov 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jim-deriv jim-deriv jim-deriv approved these changes

@heorhi-deriv heorhi-deriv heorhi-deriv approved these changes

@nijil-deriv nijil-deriv nijil-deriv approved these changes

@ali-hosseini-deriv ali-hosseini-deriv Awaiting requested review from ali-hosseini-deriv ali-hosseini-deriv is a code owner

@amina-deriv amina-deriv Awaiting requested review from amina-deriv amina-deriv is a code owner

@balakrishna-deriv balakrishna-deriv Awaiting requested review from balakrishna-deriv balakrishna-deriv is a code owner

@farrah-deriv farrah-deriv Awaiting requested review from farrah-deriv farrah-deriv is a code owner

@habib-deriv habib-deriv Awaiting requested review from habib-deriv habib-deriv is a code owner

@matin-deriv matin-deriv Awaiting requested review from matin-deriv matin-deriv is a code owner

@sandeep-deriv sandeep-deriv Awaiting requested review from sandeep-deriv sandeep-deriv is a code owner

@wojciech-deriv wojciech-deriv Awaiting requested review from wojciech-deriv wojciech-deriv is a code owner

@yashim-deriv yashim-deriv Awaiting requested review from yashim-deriv yashim-deriv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@lubega-deriv @coveralls @nijil-deriv @heorhi-deriv @jim-deriv